Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HSMs #7

Merged
merged 7 commits into from
Jul 16, 2020
Merged

Add support for HSMs #7

merged 7 commits into from
Jul 16, 2020

Conversation

doanac
Copy link
Member

@doanac doanac commented Jul 7, 2020

This adds support to fioconfig for working with HSMs. It requires a patch to crytpo11:

ThalesGroup/crypto11#70

doanac added 6 commits June 26, 2020 16:00
This lets us connect to the device-gateway via TLS

Signed-off-by: Andy Doan <[email protected]>
We are going to update this in a way that probably can't be merged
upstream. This was copied from:

 https://github.com/ethereum/go-ethereum/blob/02cea2330d6b4822b43a7fbaeacc12ddc8e8b1db/crypto/ecies/ecies.go

Signed-off-by: Andy Doan <[email protected]>
This required some golang tidy updates and I removed the unused
functions.

Signed-off-by: Andy Doan <[email protected]>
@doanac doanac requested a review from ricardosalveti July 7, 2020 15:51
@doanac
Copy link
Member Author

doanac commented Jul 7, 2020

@ricardosalveti - unit tests aren't going to be able to pass because of the required patch.

This is a temporary work-around while the PR gets sorted out:

 ThalesGroup/crypto11#70

Signed-off-by: Andy Doan <[email protected]>
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this work!

@ricardosalveti ricardosalveti merged commit 9713f2b into foundriesio:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants