Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly console log for Windows #1029

Closed
2 tasks done
ghost opened this issue Mar 23, 2022 · 4 comments
Closed
2 tasks done

Ugly console log for Windows #1029

ghost opened this issue Mar 23, 2022 · 4 comments
Labels
C-cast Command: cast C-forge Command: forge D-chore Difficulty: chore P-normal Priority: normal T-bug Type: bug

Comments

@ghost
Copy link

ghost commented Mar 23, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

0.2.0 ( latest )

What command(s) is the bug in?

forge test

Operating System

Windows

Describe the bug

Capture (4)

Running forge test on Windows produces ugly console output which is not very formatted unlike the one from Linux

@ghost ghost added the T-bug Type: bug label Mar 23, 2022
@mattsse
Copy link
Member

mattsse commented Mar 23, 2022

thanks for this!
can you share some details of the terminal you used?

I think we should somehow check if the terminal supports colors, maybe the atty crate supports this

@onbjerg
Copy link
Member

onbjerg commented Mar 23, 2022

It's because your terminal does not support ANSI escape sequences. As far as I know there is no real way to test if it does without matching against a known set of terminals that do (this is what terminfo is for)

@onbjerg onbjerg added C-cast Command: cast C-forge Command: forge P-normal Priority: normal D-chore Difficulty: chore labels Mar 23, 2022
@ghost
Copy link
Author

ghost commented Mar 24, 2022

@mattsse @onbjerg It would be a plain cmd console from Windows.

Trying from Powershell

Capture (5)

From Git bash

Capture (6)

I assume that UNIX like bash system is the only working command line tool for this console output

@onbjerg onbjerg added this to Foundry Apr 17, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 17, 2022
@onbjerg
Copy link
Member

onbjerg commented Apr 30, 2022

Fixed in #1450

@onbjerg onbjerg closed this as completed Apr 30, 2022
Repository owner moved this from Todo to Done in Foundry Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast C-forge Command: forge D-chore Difficulty: chore P-normal Priority: normal T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

2 participants