Add support for AppSync alarms and dashboard #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant resources
direnakkoc
force-pushed
the
appsync-metrics
branch
from
9396cf3 to
9af9274
Compare
eoinsha
requested changes
Nov 28, 2022
core/dashboard.js
Outdated
| function createAppSyncWidgets (appSyncResources) { | ||
| const appSyncWidgets = [] | ||
| const metricGroups = { | ||
| CloudWatch: ['5XXError', '4XXError', 'Latency', 'Requests'], |
There was a problem hiding this comment.
Maybe "API" makes more sense here than "CloudWatch" as a group label
core/dashboard.js
Outdated
| function createAppSyncWidgets (appSyncResources) { | ||
| const appSyncWidgets = [] | ||
| const metricGroups = { | ||
| CloudWatch: ['5XXError', '4XXError', 'Latency', 'Requests'], |
There was a problem hiding this comment.
We will have to use different y-axes for metrics of different units
| @@ -16,7 +16,7 @@ custom: | |||
| - Key: Stage | |||
| Value: ${self:provider.stage} | |||
| slicWatch: | |||
| topicArn: ${env:ALARM_TOPIC} | |||
| # topicArn: ${env:ALARM_TOPIC} | |||
There was a problem hiding this comment.
This comment # should be removed before merge
| - ALLOW_REFRESH_TOKEN_AUTH | ||
| PreventUserExistenceErrors: ENABLED | ||
|
|
||
| #Cognito users pool Admin group |
There was a problem hiding this comment.
You can add a space after all comment markers (#).
| @@ -8,7 +8,7 @@ plugins: | |||
| - serverless-slic-watch-plugin | |||
| custom: | |||
| slicWatch: | |||
| topicArn: ${env:ALARM_TOPIC} | |||
| # topicArn: ${env:ALARM_TOPIC} | |||
There was a problem hiding this comment.
Remove comment before merge
direnakkoc
force-pushed
the
appsync-metrics
branch
from
ae0fb6c to
b663cc9
Compare
- Tidy up the branch
direnakkoc
force-pushed
the
appsync-metrics
branch
from
b663cc9 to
8afae38
Compare
|
Already merged as part of #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for AppSync alarms for the metrics are:
Add support for AppSync dashboard for the metrics are:
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: