Union processing fix proposed #44
Conversation
Currently a union instance saves its data by taking the longest field in the union. Bit it doesn't guarantee it's proper data after some field has been modified there. The fix fixes the issue.
|
Currently a union instance saves its data by taking the longest field in the union. But it doesn't guarantee it's proper data after some field has been modified there. The fix fixes the issue. |
|
Wanted to give a short status update here. I've been trying out my idea of having "proxy" objects only for unions to hopefully not impact performance too much for other structures. I've got it mostly working, just need to figure out a solution for anonymous unions. If that doesn't work out, I'll probably end up making some suggestions to your PR that ends up being somewhere in the middle. |
|
Another small update. I've decided to only work on adding this feature to the upcoming cstruct "v4" (#35). The way how I wanted to incorporate this is a lot easier with the new type model introduced there. You can view my solution in the linked PR (#49). It would be interesting to learn if all of your use-cases are covered by that branch. |
|
#49 has since been merged into the v4 branch. It won't be long until we merge that into main. I'll close this PR but would like to thank you for the idea and suggestion! |
Currently a union instance saves its data by taking the longest field in the union. Bit it doesn't guarantee it's proper data after some field has been modified there. The fix fixes the issue.