Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling structures with a reserved keyword name #66

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jan 6, 2024

Fixes #65.

No fix is needed in #35 as the compiler already works different there. That's also why I chose a simple fix for this branch, instead of a more in-depth fix in the compiler: it's going to get replaced entirely soon.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7eb3cce) 89.01% compared to head (3accd56) 89.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   89.01%   89.04%   +0.02%     
==========================================
  Files          20       20              
  Lines        1857     1862       +5     
==========================================
+ Hits         1653     1658       +5     
  Misses        204      204              
Flag Coverage Δ
unittests 89.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic self-requested a review January 9, 2024 09:54
@Schamper Schamper merged commit a25e25a into main Jan 9, 2024
@Schamper Schamper deleted the fix-keyword-name branch January 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword conflicting with Python
2 participants