Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LEB128 variable-lengh integer support to cstruct v3 #73

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

joost-j
Copy link
Contributor

@joost-j joost-j commented Mar 4, 2024

Backport for #69. Basically copy-pasted the implementation from the v4 version, but slightly edited some implementation / test details to work with the cstruct v3 API.

@joost-j joost-j requested a review from Schamper March 25, 2024 15:13
@joost-j joost-j requested a review from Schamper March 25, 2024 15:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (772d473) to head (98c3553).

Files Patch % Lines
dissect/cstruct/types/leb128.py 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   89.09%   89.50%   +0.41%     
==========================================
  Files          20       21       +1     
  Lines        1870     1924      +54     
==========================================
+ Hits         1666     1722      +56     
+ Misses        204      202       -2     
Flag Coverage Δ
unittests 89.50% <94.44%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joost-j joost-j requested a review from Schamper March 26, 2024 12:28
@Schamper Schamper merged commit 8ce999f into fox-it:main Mar 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants