-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for long non-residential symlinks #35
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 64.50% 65.47% +0.96%
==========================================
Files 4 4
Lines 417 420 +3
==========================================
+ Hits 269 275 +6
+ Misses 148 145 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1964468
to
f65cd0b
Compare
tests/data/.gitattributes
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's maybe a bit nicer to have this file in tests/data
, it's more consistent with other dissect projects to have it in the project root instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there already was a .gitattributes
in the project root, so it is also more consistent with this project :)
Fixed.
The targets of non-residential symlinks were not completely read. This is because the size of the symlink header was not taken into account on XFS version 5.
Added a test with a very long symlink and also check number of blocks.
Bonus:
Closes #34