ros: Remove ImageMarkerArray #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Mar 1, 2025
ros/foxglove_msgs/package.xml
Outdated
| @@ -19,7 +19,7 @@ | |||
| <build_depend condition="$ROS_VERSION == 2">rosidl_default_generators</build_depend> | |||
| <build_depend>ros_environment</build_depend> | |||
|
|
|||
| <depend>visualization_msgs</depend> | |||
| <depend>builtin_interfaces</depend> | |||
There was a problem hiding this comment.
Hm - this seems like it should be conditional on ROS 2. If we don't plan to ever publish for ROS 1 again, then we should remove all the conditional stuff.
There was a problem hiding this comment.
Good catch, updated.
I doubt we will publish any more ROS 1 updates but we can remove all that in another PR.
There was a problem hiding this comment.
We should still be considerate of folks building ROS 1 things from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Drop support for
foxglove_msgs/ImageMarkerArrayDocs
None
Description
foxglove_msgs/ImageMarkerArraywas a hack that we used to support multiple image annotations on an image. It predates Foxglove schemas, and foxglove_msgs/ImageAnnotations has been our recommended way to display multiple image annotations for several years.