Change the intermediate representation for rendering #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a set of intermediate data types as a stepping stone between our strongly-controlled diff result types (
DiffResult,DiffErrorNestedetc), and our destination render type (a lazy textBuilder). The intermediate types were basically untyped versions of our diff result types - in other words, were further towards that end of the scale. In this PR we change the intermediate type to something much closer to the middle.Docis a very simple type, allowing rendering to output some lines, plus an optional nestedDoc.In a future PR when we let the user extend our error types with custom diffs, this will help a lot in structuring how they can render those diffs.