Review Task 2 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch4ron
reviewed
Mar 26, 2020
| import java.text.SimpleDateFormat; | ||
| import java.util.Date; | ||
|
|
||
| public class AbstractComment { |
ch4ron
reviewed
Mar 26, 2020
| } | ||
|
|
||
| public void markConversation(Line line) { | ||
| // Nothing to do, it's perfect. |
ch4ron
reviewed
Mar 26, 2020
| } | ||
|
|
||
| public static SourceFile createFromString(String sourceCode, String language) { | ||
| return new SourceFile(sourceCode, language); |
ch4ron
reviewed
Mar 26, 2020
| /** | ||
| * Creates source file based on a file reference. | ||
| */ | ||
| public static SourceFile createFromFile(File sourceFile) throws IOException { |
There was a problem hiding this comment.
createSourceFileFromFile or copySourceFile
benroszko
reviewed
Mar 27, 2020
Comment on lines
+26
to
+33
| public void setFile(File file) { | ||
| checkValidType(AbstractComment.Type.VOICE); | ||
| this.file = file; | ||
| } | ||
|
|
||
| public File getFile() { | ||
| checkValidType(AbstractComment.Type.VOICE); | ||
| return file; |
There was a problem hiding this comment.
checkValiType() powinna byc w innym miejscu, setter i getter powinny tylko ustawiac i pobierac wartosc zmiennej
|
|
||
| import android.content.Context; | ||
| import android.graphics.Color; | ||
| import android.view.View; |
Comment on lines
+26
to
+30
| if (selectedLine != null) { | ||
| selectedLine.setBackgroundColor(Color.TRANSPARENT); | ||
| } | ||
| selectedLine = (Line) view; | ||
| selectedLine.setBackgroundColor(SELECTED_LINE_COLOR); |
Comment on lines
+54
to
+56
| for (int i = 0; i < digest.length; i++) { | ||
| sb.append(Integer.toString((digest[i] & 0xff) + 0x100, 16).substring(1)); | ||
| } |
There was a problem hiding this comment.
rowniez mozna wydzielic do prywatnej metody
Comment on lines
+66
to
+70
| while (tokenizer.hasMoreTokens()) { | ||
| Line line = new Line(context, this, lines.size() + 1, tokenizer.nextToken()); | ||
| line.setOnClickListener(lineHighlighter); | ||
| lines.add(line); | ||
| } |
Comment on lines
+83
to
+87
| if (ApplicationSettings.highlightSources()) { | ||
| return SYNTAX_HIGHLIGHTER.highlight(code, language); | ||
| } else { | ||
| return code; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find as many defects and problems as possible!
You can skip the
Line.javaas you have already saw it in the Task 1.