Os stdlib module and separation of Eval/External module #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian3k
reviewed
Oct 15, 2024
lib/Os.fram
Outdated
|
|
||
| pub let fileExists = (extern dbl_fileExists : String ->[IO] Bool) | ||
|
|
||
| pub let isDirectory {`re : {X} -> Unit -> [|_]X } name = |
There was a problem hiding this comment.
To be consistent with existing code:
Suggested change
| pub let isDirectory {`re : {X} -> Unit -> [|_]X } name = | |
| pub let isDirectory {`re : {X} -> Unit ->[|_] X } name = |
Florian3k
reviewed
Oct 15, 2024
lib/Os.fram
Outdated
| then (extern dbl_isDirectory : String ->[IO] Bool) name | ||
| else `re () | ||
|
|
||
| pub let isRegularFile {`re : {X} -> Unit -> [|_]X } name = |
There was a problem hiding this comment.
Same here:
Suggested change
| pub let isRegularFile {`re : {X} -> Unit -> [|_]X } name = | |
| pub let isRegularFile {`re : {X} -> Unit ->[|_] X } name = |
Florian3k
reviewed
Oct 15, 2024
lib/Os.fram
Outdated
| pub let getUnixTime = (extern dbl_getUnixTime : Unit ->[IO] Int) | ||
|
|
||
| (* calculate date and time stamp from unix time *) | ||
| pub let getTime {`re : {X} -> Unit -> [|_]X } () = |
There was a problem hiding this comment.
and here:
Suggested change
| pub let getTime {`re : {X} -> Unit -> [|_]X } () = | |
| pub let getTime {`re : {X} -> Unit ->[|_] X } () = |
Looking at external function list made me think that there are too many of them for one file, so i seperated them into modules making it easier for extending functionality. Implemented functionality that will allow for some system manipulation, accessing environment variables, program arguments and system time. Can be extended if there will be need for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at external function list made me think that there are too many
of them for one file, so i seperated them into modules making it easier
for extending functionality.
Implemented functionality that will allow for some system manipulation,
accessing environment variables, program arguments and system time.
Can be extended if there will be need for it.
Didn't write any tests since it's almost only linking of external functions from ocaml.
This PR is dependent on #126