New implementation of block commets #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of block comments is changed, as proposed in the documentation of Fram.
forell
approved these changes
Dec 15, 2024
|
I think, I was loud enough on discord, and we've got positive feedback on Friday. But I would still wait, until you accept (or reject?) another pull-request to the documentation. If it will be accepted, I can change the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of block comments is changed, as proposed in the documentation of Fram.
We can wait with merging this PR, until we agree on the approach to block comments. But I hope, this PR shows that the solution proposed in #166 has a simple implementation.
Fixes #166