Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the parser, Raw and Desugar #178

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Conversation

forell
Copy link
Member

@forell forell commented Jan 9, 2025

The parser is updated to match the new version of Surface. Miscellanous syntax changes requested in existing issues or discussed elsewhere were made too:

The tests and examples should mostly parse now, though not necessarily as expected due to the changes to method definitions.

The parser is updated to match the new version of Surface. Miscellanous
syntax changes requested in existing issues or discussed elsewhere were
made too:
* #156 method definitions no longer treat self in a special way, but
  the tests were not updated;
* #173;
* effect variable naming near the `handle` construct uses `/`;
* no more rows and `effect` or `label` fields (but the keyword `label`
  still cannot be used as an identifier).

The tests and examples should mostly parse now, though not necessarily
as expected due to the changes to method definitions.
@forell forell requested a review from ppolesiuk January 9, 2025 15:02
Copy link
Member

@ppolesiuk ppolesiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good. I think that after changes one of functions in Desugar is redundant (see comment below). Could you check if it is true? If so, the function should be removed, and then the changes can be merged.

src/DblParser/Desugar.ml Outdated Show resolved Hide resolved
@forell forell merged commit 19618be into effect-inference Jan 12, 2025
0 of 2 checks passed
@forell forell deleted the effect-inference-parser branch January 12, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants