Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early abort of pipeline in REPL #67

Merged
merged 4 commits into from
May 8, 2024
Merged

Early abort of pipeline in REPL #67

merged 4 commits into from
May 8, 2024

Conversation

ppolesiuk
Copy link
Member

Fixes #66

Normally, pipeline calls Interplib.Error.assert_no_error before starting the next phase. But in REPL phases are interleaved, so I additional calls of Interplib.Error.assert_no_error after translating each piece of code provided by the user in REPL.

@ppolesiuk ppolesiuk requested a review from forell May 7, 2024 13:05
Copy link
Member

@forell forell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@forell forell merged commit 3416da7 into master May 8, 2024
2 checks passed
@forell forell deleted the 66-repl-bug-fix branch May 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-fatal errors in REPL do not abort the pipeline
2 participants