Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the not-found page HTTP header to 404 #786

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Set the not-found page HTTP header to 404 #786

merged 2 commits into from
Jun 27, 2024

Conversation

AliKdhim87
Copy link
Contributor

@AliKdhim87 AliKdhim87 commented Jun 21, 2024 •
edited
Loading

@AliKdhim87 AliKdhim87 requested a review from Robbert June 21, 2024 10:19
@AliKdhim87 AliKdhim87 force-pushed the set-the-404-page-http-header-to-404 branch from b7388dc to c834a5f Compare June 21, 2024 10:50
@AliKdhim87 AliKdhim87 linked an issue Jun 21, 2024 that may be closed by this pull request
Correct HTTP status header for error pages #781
Open
2 tasks
Robbert
Robbert reviewed Jun 22, 2024
View reviewed changes
Copy link
Member

@Robbert Robbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the exotic HTTP header, it doesn't seem very DRY to have 5 not found pages for two projects...

apps/pdc-frontend/src/app/[locale]/(rootLayout)/[...not-found]/page.tsx Outdated Show resolved Hide resolved
@AliKdhim87 AliKdhim87 force-pushed the set-the-404-page-http-header-to-404 branch from c834a5f to a75f324 Compare June 24, 2024 07:51
@AliKdhim87 AliKdhim87 requested a review from Robbert June 24, 2024 08:56
@AliKdhim87 AliKdhim87 force-pushed the set-the-404-page-http-header-to-404 branch from a75f324 to 35ba863 Compare June 24, 2024 11:45
@Robbert Robbert enabled auto-merge (rebase) June 27, 2024 07:48
@Robbert Robbert merged commit 49cc290 into main Jun 27, 2024
2 checks passed
@Robbert Robbert deleted the set-the-404-page-http-header-to-404 branch June 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert Robbert Robbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct HTTP status header for error pages
2 participants
@AliKdhim87 @Robbert