Fix PHP warning undefined array key

francoisjacquet · Oct 11, 2023 · 3c3a940 · 3c3a940
1 parent a5023ce
commit 3c3a940
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/Grades/ReportCardComments.php b/modules/Grades/ReportCardComments.php
@@ -132,7 +132,7 @@
 				AND GRADE_SCALE_ID IS NOT NULL)>0
 			ORDER BY SORT_ORDER IS NULL,SORT_ORDER,TITLE", [], [ 'SUBJECT_ID' ] );
 
-		if ( ! $_REQUEST['subject_id'] || ! $subjects_RET[$_REQUEST['subject_id']] )
+		if ( ! $_REQUEST['subject_id'] || empty( $subjects_RET[$_REQUEST['subject_id']] ) )
 		{
 			$_REQUEST['subject_id'] = key( $subjects_RET ) . '';
 		}
@@ -148,7 +148,7 @@
 				AND GRADE_SCALE_ID IS NOT NULL)>0
 			ORDER BY TITLE", [], [ 'COURSE_ID' ] );
 
-		if ( ! $_REQUEST['course_id'] || ! $courses_RET[$_REQUEST['course_id']] )
+		if ( ! $_REQUEST['course_id'] || empty( $courses_RET[$_REQUEST['course_id']] ) )
 		{
 			$_REQUEST['course_id'] = key( $courses_RET ) . '';
 		}