Remap joint states instead of re-publish #192
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-publishing
joint_states
viajoint_state_publisher
(a python app) is highly inefficient.IMO remapping would be the right way to go instead - as long nobody needs the published topics on the namespace
franka_state_controller
/franka_gripper
.But, remapping has its drawbacks too:
franka_state_controller/joint_states
and/orfranka_gripper/joint_states
joint_states
messages from arm and gripper are published both to the same topic, so we cannot easily distinguish them anymore (w/o looking at the message of course)rqt_plot
.Note: This PR includes #191.