Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load descriptions if desired #202

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

fjulian
Copy link

@fjulian fjulian commented Nov 18, 2021

Give the option to use a custom robot URDF when launch franka_control or franka_gazebo.

@gollth
Copy link
Contributor

gollth commented Aug 1, 2022

Hi @fjulian and sorry for the late reply. Thanks for your interest in and your contribution to franka_ros. May I ask what use case you are covering with not loading the URDF onto the parameter server?

@fjulian
Copy link
Author

fjulian commented Aug 15, 2022

Hi @gollth, thanks for the reply. The use case for this is to load a custom robot description, e.g. with a camera or a mobile base added to the arm. In that case, I would like to load a description in an outer launch file, but with the current launch files, it would be overwritten again. Having this flag would allow to avoid this.
Admittedly, this could also be solved with namespacing. However, I think it would be nice to have both options, allowing users to choose what they prefer, especially since my proposed solution keeps the default behavior the same.

kmohyeldin pushed a commit that referenced this pull request Sep 2, 2022
…velop

* commit '5ac75b45046aecd5bf877fce42c1ea9f5c8c9bdb':
  release 0.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants