Some improvements to efficiency #290
Open
+14
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
improve-efficiency
branch
from
1055738 to
ae57b33
Compare
... when only singular values are needed. Actually, it might suffice to compute the determinant!
rhaschke
force-pushed
the
improve-efficiency
branch
2 times, most recently
from
349c3c9 to
7ddaeb2
Compare
Considering S as a rectangular matrix when only the diagonal elements are relevant is vasting computing resources in matrix multiplication.
rhaschke
force-pushed
the
improve-efficiency
branch
from
7ddaeb2 to
092ae94
Compare
|
@rhaschke, significant improvements; I used them on my fork! @Maverobot, could we please consider merging these changes into the |
rickstaa
approved these changes
Sep 4, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.