Remove enforcement of C++14 standard #370
Open
+16
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
approved these changes
Nov 22, 2023
5 tasks
Compilers already default to C++17 nowadays and log4cxx requires C++17 on Ubuntu Jammy.
Boost 1.73 depreacated the implicit use of boost::placeholders.
|
still (and by now more) relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove enforcement of C++14 standard. Modern defaults are:
Thus, C++14 is satisfied automatically on these systems.
However, on Ubuntu 22.04, log4cxx requires C++17 (which is the default).
Enforcing C++14 downgrades the standard, rendering log4cxx uncompilable.