Prefer LibSecret over KWallet also for KDE. Resolves #220 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Bidar <[email protected]>
|
This might have been on purpose, some time ago there were cases where libsecret was present but not really functional. Not sure if that's still the case, need to check Kubuntu 18.04 or similar. |
|
On Kubuntu 18.04 nothing should change as there is no SecretService running in
a KDE session with that version.
|
|
Probably better wait with this one. The Secret Service support in KWallet is still brand new, and suffers from some bugs/limitations: Until 458644 is fixed, this comment is still true:
It would be better to update and merge #75 instead for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.