Rust code #21
Open
Rust code #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| impl From<std::string::FromUtf8Error> for HglibError { | ||
| fn from(err: std::string::FromUtf8Error) -> HglibError { | ||
| HglibError::Str(format!("Hglib error: {}", err)) | ||
| } |
There was a problem hiding this comment.
Nit... but... So... are you sure about this 🐼 pandas?
| @@ -0,0 +1,177 @@ | |||
| extern crate byteorder; | |||
| extern crate subprocess; | |||
|
|
|||
There was a problem hiding this comment.
Henlo friend. 🦄 Are you sure about this?⚡
| self.close().unwrap(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Me again, just one more nit...🌈 Meeps Meeps... this looks weird...
| encoding, | ||
| }; | ||
| Ok(client) | ||
| } |
There was a problem hiding this comment.
Henlo friend. 🦄 Woah... this old bit again... 🦄
| HglibError::Str(format!("Hglib error: {}", err)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Henlo friend. 🦄 Something looks weird here. Are you sure about this? 🌈
| fn from(err: std::str::Utf8Error) -> HglibError { | ||
| HglibError::Str(format!("Hglib error: {}", err)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Hrmmm... Woah... this old bit again... 🦄
|
|
||
| pub struct Client { | ||
| server: Popen, | ||
| encoding: String, |
There was a problem hiding this comment.
Nit... but... Meeps Meeps... this looks weird...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.