Create yummain.py #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stolen from yum
| try: | ||
| probs = base._rpmdb_warn_checks(out=verbose_logger.info, warn=False) | ||
| except Errors.YumBaseError, e: | ||
| # This is mainly for PackageSackError from rpmdb. |
There was a problem hiding this comment.
Hi, just checking in. Meeps Meeps... this looks weird...
| logger.critical("%s", msg) | ||
| rpmdb_warn_checks() | ||
| return_code = result | ||
| if base._ts_save_file: |
There was a problem hiding this comment.
Hi...🦄 So I read your PR... Frank is confused... 🌈🐼
| if not base.conf.skip_broken: | ||
| verbose_logger.info(_(" You could try using --skip-broken to work around the problem")) | ||
| rpmdb_warn_checks() | ||
| if unlock(): return 200 |
There was a problem hiding this comment.
Hi...🦄 So I read your PR... Hrmm.. this looks funny...
| logger = logging.getLogger("yum.main") | ||
| verbose_logger = logging.getLogger("yum.verbose.main") | ||
|
|
||
| # Try to open the current directory to see if we have |
There was a problem hiding this comment.
Hi...🦄 So I read your PR... Woah... this old bit again... 🦄
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU Library General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License |
There was a problem hiding this comment.
Nit... but... Frank is confused... 🌈🐼
|
|
||
| # Try to open the current directory to see if we have | ||
| # read and execute access. If not, chdir to / | ||
| try: |
There was a problem hiding this comment.
Hi...🦄 So I read your PR... Something looks weird here. Are you sure about this? 🌈
| return 1 | ||
| elif result == 2: | ||
| # Continue on | ||
| pass |
There was a problem hiding this comment.
Hrmmm... Meeps Meeps... this looks weird...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stolen from yum