fix: prevent adding items via barcode if not tracked in inventory

frappe · Jan 2, 2025 · 26a5e02 · 26a5e02
1 parent a07376b
commit 26a5e02
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/components/Controls/WeightEnabledBarcode.vue b/src/components/Controls/WeightEnabledBarcode.vue
@@ -92,11 +92,19 @@ export default defineComponent({
             barcode: barcode.slice(checkDigits, checkDigits + itemCodeDigits),
           }
         : { barcode };
-      const fields = isWeightEnabled ? ['name', 'unit'] : ['name'];
+      const fields = isWeightEnabled
+        ? ['name', 'unit', 'trackItem']
+        : ['name', 'trackItem'];
 
       const items =
         (await this.fyo.db.getAll('Item', { filters, fields })) || [];
-      const { name, unit } = items[0] || {};
+      const { name, unit, trackItem } = items[0] || {};
+
+      if (!trackItem) {
+        return this.error(
+          this.t`Item ${name as string} is not an Inventory Item.`
+        );
+      }
 
       if (!name) {
         return this.error(this.t`Item with barcode ${barcode} not found.`);