bugfix: allow vertical scroll in sidebar #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayitzme
reviewed
Jan 2, 2025
fyo/model/doc.ts
Outdated
| @@ -344,14 +368,17 @@ export class Doc extends Observable<DocValue | Doc[]> { | |||
| value?: DocValue | Doc[] | DocValueMap[] | |||
| ): boolean { | |||
| if (fieldname === 'numberSeries' && !this.notInserted) { | |||
| // console.log("cannot set %s, numberSeries inserted", fieldname) | |||
There was a problem hiding this comment.
Please remove the redundant code
akshayitzme
reviewed
Jan 2, 2025
fyo/model/doc.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| if (value === undefined) { | ||
| // console.log("cannot set %s, undefined value", fieldname) |
akshayitzme
reviewed
Jan 2, 2025
fyo/model/doc.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| if (this.fieldMap[fieldname] === undefined) { | ||
| // console.log("cannot set %s, no fieldMap", fieldname, this.fieldMap) |
mildred
force-pushed
the
mildred/sidebar-vertical-scroll
branch
from
6c07386 to
8d6284f
Compare
|
@akshayitzme I updated the code following your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains also commits from #1023 which it would conflict with otherwise