Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submit and hold invoice for later use in POS #1065

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

AbleKSaju
Copy link
Contributor

No description provided.

@AbleKSaju AbleKSaju marked this pull request as draft December 23, 2024 06:06
@AbleKSaju AbleKSaju marked this pull request as ready for review January 3, 2025 09:46
@@ -571,13 +582,26 @@ export default defineComponent({
await this.applyPricingRule();
await this.sinvDoc.runFormulas();
},

async createTransaction(shouldPrint = false) {
async createTransaction(shouldPrint = false, isPay = false) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPay should be renamed to makePayment or createPayment or something else that suits the action that's performed.

@akshayitzme akshayitzme merged commit 352ecee into frappe:master Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants