fix: show validation message before changing shift start time #2742
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: added tests
|
@ruchamahabal, is better way to just call fetch shift on the logs after start time is changed? |
asmitahase
force-pushed
the
shift-settings
branch
from
89cdf89 to
abe4f37
Compare
| if self.is_field_modified("start_time") and self.unlinked_checkins_exist(): | ||
| frappe.throw( | ||
| title=_("Unmarked Check-in Logs Found"), | ||
| msg=_("Mark attendance for exsiting check-in/out logs before changing shift settings"), |
There was a problem hiding this comment.
Suggested change
| msg=_("Mark attendance for exsiting check-in/out logs before changing shift settings"), | |
| msg=_("Mark attendance for existing check-in/out logs before changing shift settings"), |
Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shift start time is recorded in the Employee checkins which is then used to sort the logs chronologically to mark attendance.
If this is time is changed mid shift, check in and check out logs get a different shift start which results in incorrect attendance records
Before
Screen.Recording.2025-02-01.at.12.26.54.AM.mov
After
Screen.Recording.2025-02-01.at.1.13.57.AM.mov
Solution
Show a validation before changing start time to mark attendance for unlinked logs.