Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: multiple checkin logs #2773

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

asmitahase
Copy link
Collaborator

@asmitahase asmitahase commented Feb 9, 2025

Problem

Employee checkins have miliseconds info, so checkins created within a second pass the validate duplicate log check. They appear in the list however as duplicate checkins
Also, refactored the checkin button as reviewed
#2604 (review)

Before

Screen.Recording.2025-01-09.at.1.22.52.PM.mov

After

Screen.Recording.2025-02-10.at.9.33.52.AM.mov

@asmitahase asmitahase marked this pull request as ready for review February 10, 2025 04:07
@asmitahase asmitahase merged commit 9ff29f2 into frappe:develop Feb 10, 2025
7 checks passed
@asmitahase asmitahase deleted the multiple-checkins branch February 10, 2025 08:37
asmitahase added a commit that referenced this pull request Feb 10, 2025
…2773

refactor: multiple checkin logs (backport #2773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant