Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use web view for job opening (backport #2779) #2780

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 11, 2025

Use web view for job opening. Will open a separate PR for refactoring templates.


This is an automatic backport of pull request #2779 done by Mergify.

(cherry picked from commit bc49885)

# Conflicts:
#	hrms/hr/doctype/job_opening/job_opening.json
#	hrms/hr/doctype/job_opening/templates/job_opening_row.html
@mergify mergify bot requested a review from ruchamahabal as a code owner February 11, 2025 20:49
@mergify mergify bot added the conflicts label Feb 11, 2025
Copy link
Contributor Author

mergify bot commented Feb 11, 2025

Cherry-pick of bc49885 has failed:

On branch mergify/bp/version-14-hotfix/pr-2779
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit bc498851.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   hrms/hr/doctype/job_opening/templates/job_opening.html

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/job_opening/job_opening.json
	both added:      hrms/hr/doctype/job_opening/templates/job_opening_row.html

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@asmitahase asmitahase merged commit 6620edf into version-14-hotfix Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant