fix: validation for circular shift times #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if total_minutes >= 1440: | ||
| frappe.throw( | ||
| title=_("Invalid Shift Times"), | ||
| msg=_("Please change shift times or buffers to avoid overlap."), |
There was a problem hiding this comment.
The message is unclear. Point to the exact fields we need to change. "buffers" is unclear
There was a problem hiding this comment.
Also, maybe explicitly say, shift timings are overlapping with itself
Overlapping with what is ambiguous
test: validation for circular shift times
asmitahase
force-pushed
the
circular-shifts
branch
from
ac1126f to
1a310ac
Compare
asmitahase
added a commit
that referenced
this pull request
Feb 20, 2025
…2783 fix: validation for circular shift times (backport #2783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process Auto attendance breaks for circular overlapping shifts, hence the validation
Screen.Recording.2025-02-19.at.2.24.00.PM.mov