Merge pull request #1255 from pateljannat/batch-url

refactor: changed batch naming to be a slug of the title

lms/lms/doctype/lms_batch/lms_batch.json

@@ -2,7 +2,6 @@
  "actions": [],
  "allow_import": 1,
  "allow_rename": 1,
- "autoname": "format: CLS-{#####}",
  "creation": "2022-11-09 16:14:05.876933",
  "default_view": "List",
  "doctype": "DocType",
@@ -330,11 +329,10 @@
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2024-11-18 16:28:41.336928",
+ "modified": "2025-01-17 10:23:10.580311",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Batch",
- "naming_rule": "Expression (old style)",
  "owner": "Administrator",
  "permissions": [
   {

lms/lms/doctype/lms_batch/lms_batch.py

@@ -16,6 +16,7 @@
 	get_quiz_details,
 	get_assignment_details,
 	update_payment_record,
+	generate_slug,
 )
 from frappe.email.doctype.email_template.email_template import get_email_template
 
@@ -36,6 +37,10 @@ def validate(self):
 		self.validate_evaluation_end_date()
 		self.add_students_to_live_class()
 
+	def autoname(self):
+		if not self.name:
+			self.name = generate_slug(self.title, "LMS Batch")
+
 	def validate_batch_end_date(self):
 		if self.end_date < self.start_date:
 			frappe.throw(_("Batch end date cannot be before the batch start date"))

lms/lms/doctype/lms_course/lms_course.py

@@ -93,10 +93,7 @@ def send_email_to_interested_users(self):
 
 	def autoname(self):
 		if not self.name:
-			title = self.title
-			if self.title == "New Course":
-				title = self.title + str(random.randint(0, 99))
-			self.name = generate_slug(title, "LMS Course")
+			self.name = generate_slug(self.title, "LMS Course")
 
 	def __repr__(self):
 		return f"<Course#{self.name}>"