Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Admin Dashboard #68

Merged
merged 73 commits into from
Feb 7, 2025
Merged

feat: Admin Dashboard #68

merged 73 commits into from
Feb 7, 2025

Conversation

krantheman
Copy link
Member

@krantheman krantheman commented Jan 28, 2025 •
edited
Loading

Domains

Screenshots

List

image

Add Domain

image

image

Domain Settings

image

Members

Screenshots

List

image

Add Member

image

image

Mail Account Request

  • Role (Select) field -> Is Admin (Checkbox)
  • Form UX
  • Validations

Other

  • Upgrade frappe-ui to v0.1.108
  • Downgrade vite to v5 (frappe-ui compatibility)
  • Fix email css build
  • Routing
    • Administrator -> /desk
    • Mail Admin w/o account -> /mail/dashboard
    • Mail Admin w/ account -> /mail/inbox
    • Mail User w/ account-> /mail/inbox
    • Mail User w/o account -> ??

@krantheman krantheman changed the title feat: add Domains page feat: add Admin Dashboard Jan 28, 2025
@krantheman krantheman changed the title feat: add Admin Dashboard feat: Admin Dashboard Jan 28, 2025
s-aga-r
s-aga-r requested changes Jan 29, 2025
View reviewed changes
mail/mail/doctype/mail_domain/mail_domain.json Outdated Show resolved Hide resolved
mail/api/admin.py Outdated Show resolved Hide resolved
@krantheman krantheman force-pushed the feat-admin-dashboard branch from a81a8cf to 9708ba2 Compare February 6, 2025 12:33
@krantheman krantheman force-pushed the feat-admin-dashboard branch from 9708ba2 to c9457e2 Compare February 6, 2025 12:36
@krantheman krantheman force-pushed the feat-admin-dashboard branch 2 times, most recently from a194d7e to adf0f10 Compare February 6, 2025 13:06
@krantheman krantheman force-pushed the feat-admin-dashboard branch from adf0f10 to c1e1f76 Compare February 6, 2025 13:09
s-aga-r
s-aga-r reviewed Feb 7, 2025
View reviewed changes
mail/api/admin.py Outdated Show resolved Hide resolved
@s-aga-r s-aga-r force-pushed the feat-admin-dashboard branch from a78992b to d0a39e4 Compare February 7, 2025 09:10
@s-aga-r s-aga-r merged commit 37068a7 into frappe:develop Feb 7, 2025
3 checks passed
@krantheman krantheman deleted the feat-admin-dashboard branch February 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-aga-r s-aga-r s-aga-r requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krantheman @s-aga-r