Log result URL at the end of run #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
requested review from
a team and
derek-ye
and removed request for
a team
derek-ye
approved these changes
May 20, 2024
This link is already present in the CLI output and our build summary. Both of these can be insufficient: 1. The CLI output is not URI-encoded, and the characters used makes the link unclickable from build logs. A slow copy/paste is necessary. 2. It's a common issue that looking at a particular build's logs is where users start, and information in the Summary is never seen 3. The Summary content may not be present if the action is not configured with Wiz API access So, logging it separately and URI-encoded should be a nice quality-of-life improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This link is already present in the CLI output and our build summary.
Both of these can be insufficient:
link unclickable from build logs. A slow copy/paste is necessary.
where users start, and information in the Summary is never seen
configured with Wiz API access
So, logging it separately and URI-encoded should be a nice
quality-of-life improvement.
The difference between encoding (L8141) or not (L8138):