Parse Scan Ids even if URI-encoded #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI itself has been fixed to emit URI-encoded URLs, so we don't need to do this ourselves.
pbrisbin
requested review from
a team,
derek-ye and
joris974
and removed request for
a team and
derek-ye
joris974
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parse the Scan Id out of the CLI output, which includes the URL. The CLI apparently changed to emit URI-encoded URLs instead of un-encoded. Something we were recently working around ourselves. This change updates the regex we use to look for well-formed GUIDs specifically, rather than any hyphenated hex value within a URL parameter (which is what just changed). This fixes the bug and makes things both simpler and more robust along the way.
Since the CLI output now includes an encoded URL, I removed our recent workaround of encoding and logging a URL ourselves.
I also made it so the Job doesn't fail entirely if we're unable to parse a Scan Id, also in the interest of keeping things robust. If our parser fails, we will now only be unable to build a summary (which users may not be doing anyway) and will set an empty
scan-idoutput.