feat: detect user's dark mode preferences automagically #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in frectonz#15, it would be handy to respect the user's preferred light/dark mode settings, if we can detect it. This only gets referenced if there isn't an explicitly set mode in their `localStorage`. This also extracts this logic to a function, so we can more easily write a multi-line conditional, but retains the ternary logic to follow the project's style preferences. Closes frectonz#15.
|
Thank you very much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #15, it would be handy to respect the user's preferred
light/dark mode settings, if we can detect it.
This only gets referenced if there isn't an explicitly set mode in their
localStorage.This also extracts this logic to a function, so we can more easily write
a multi-line conditional, but retains the ternary logic to follow the
project's style preferences.
Closes #15.
I've tested this locally with a browser that has dark mode preference, and one that doesn't, and it works 👏