Attempted fix for content_types not being applied #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output for content_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #134
Hi @fredjean
It looks like content-type checking was broken in a previous version, and our project desperately needs UTF-8 charsets set on the text-like assets we're deploying to S3.
This PR attempts to fix config-defined
content_typesnot being applied toresourcesduring sync.I'm sure there's probably a cleaner and more efficient way to do the
resource.pathtoconfig.custom_typesmatching, so I'm asking for some help... Can anyone help me clean up this code? I am by no means a Ruby developer!Thanks!
-S