Support if-then-else #37 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fredo-dedup-master # Conflicts: # Project.toml # src/schema.jl # test/runtests.jl
|
Can you revert the JSONPointer stuff? Let's keep these PRs separate. |
odow
reviewed
Jun 27, 2024
| return val_else | ||
| end | ||
| return nothing | ||
| end |
There was a problem hiding this comment.
I might have made a mistake, but I think you can write this code as:
function _if_then_else(x, schema, path)
if _validate(x, schema["if"], path) !== nothing
if haskey(schema, "else")
return _validate(x, schema["else"], path)
end
elseif haskey(schema, "then")
return _validate(x, schema["then"], path)
end
return
endbut what about the case where you have a if-then and the if fails to validate?
odow
approved these changes
Jun 29, 2024
|
We don't seem to have coverage, so I just want to double check that these are actually getting tested |
odow
reviewed
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://json-schema.org/understanding-json-schema/reference/conditionals#ifthenelse
I've updated _validate to work on
if,then,elseand it passed all tests fromdraft7folder within theJSON-Schema-Test-SuiteI've thought about making a separate pull request from #52
But this pull request includes #52😓, you can close #52 and only merge this PR