-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: windows support #149
Conversation
look for backslashes on windows, forward slashes on unix
It is not only Windows Powershell, I also met the problem in macOS. |
Out of curiosity, which terminal are you on? |
I am using Wezterm in macOS. |
Aha, I see. I would assume it's the Japanese characters that might be causing this. I've been using Wezterm for a long time without any issues, but never with Japanese characters. 😅 Anyway, I'm happy to hear you can use the adapter with the help of |
By the way, if you have the possibility, would you mind trying setting the environment variable |
By the way, if you have the time and possibility, would you mind trying setting the environment variable export LC_ALL=C |
@fredrikaverpil |
This PR introduces a distinction between forward slashes (unix) and backslashes (windows) in filepaths.
However, there's a huge problem with ANSI codes and other stuff is garbling up the JSON output from
go test -json
. Very strange. Only happens on Windows (Powershell). A workaround is to usegotestsum
as runner, which will then write to JSON file without a console roundtrip:# make gotestsum available on $PATH by installing it go install gotest.tools/gotestsum@latest
Then set the (for now undocumented/experimental)
runner
option, and instruct it to usegotestsum
instead ofgo test
:Fixes: #147