Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor consumer logic #128

Merged
merged 40 commits into from
Jun 25, 2024
Merged

refactor: refactor consumer logic #128

merged 40 commits into from
Jun 25, 2024

Conversation

donald1218
Copy link
Contributor

@donald1218 donald1218 commented Apr 24, 2024 •
edited by andy89923
Loading

Description

  • Refactor AMF App
  • Use App.Consumer to use consumer logic

@donald1218 donald1218 force-pushed the refactor/sbi-logic branch 3 times, most recently from 679e1f0 to b396ec1 Compare April 24, 2024 13:13
andy89923
andy89923 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, use UERANSIM and Test to see if there is any error.

@andy89923 andy89923 force-pushed the refactor/sbi-logic branch from 0661278 to f9a1bc7 Compare April 29, 2024 05:55
ianchen0119
ianchen0119 reviewed May 13, 2024
View reviewed changes
@ianchen0119
Copy link
Contributor

Hi @donald1218 @tim1207

Please help to update pkg/service/mock.go.

Tks!

HanHongChen
HanHongChen reviewed Jun 12, 2024
View reviewed changes
ianchen0119
ianchen0119 reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename internal/sbi/processor/callback to internal/sbi/processor/notifier

ianchen0119
ianchen0119 reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me.

ianchen0119
ianchen0119 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianchen0119 ianchen0119 merged commit 4fbee43 into free5gc:main Jun 25, 2024
3 checks passed
@donald1218 donald1218 deleted the refactor/sbi-logic branch July 4, 2024 16:45
@ex8664 ex8664 mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy89923 andy89923 andy89923 approved these changes

@ianchen0119 ianchen0119 ianchen0119 approved these changes

@ian60509 ian60509 ian60509 approved these changes

@HanHongChen HanHongChen HanHongChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@donald1218 @ianchen0119 @andy89923 @ian60509 @HanHongChen @tim1207