fix: HoldingAmfUe restore when CM-Idle #141
Conversation
|
Hi @ss920386 Could you please help to review this PR? Tks. |
| ranUe.FindAmfUe = nil | ||
| } else { | ||
| // New AmfUe | ||
| ranUe.AmfUe = amfSelf.NewAmfUe("") |
There was a problem hiding this comment.
The case of Service Request
UE context is in CM-IDLE state.
| if err != nil { | ||
| ue.AmfUe.NASLog.Errorln(err) | ||
| ranUe.AmfUe.NASLog.Errorln(err) |
There was a problem hiding this comment.
Assume that we have an existing UE context, which is in CM-CONNECTED state.
We will release it if the new UE context has a valid security context in line 53.
internal/nas/handler.go
Outdated
| if ranUe.AmfUe == nil { | ||
| if ranUe.FindAmfUe != nil && !ranUe.FindAmfUe.CmConnect(ranUe.Ran.AnType) { | ||
| // models.CmState_IDLE | ||
| gmm_common.ClearHoldingRanUe(ranUe.FindAmfUe.RanUe[ranUe.Ran.AnType]) |
There was a problem hiding this comment.
!ranUe.FindAmfUe.CmConnect(ranUe.Ran.AnType) implies that ranUe.FinAmfUe didn't have underlying ranUe, right?
Shouldn't ClearHoldingRanUe(ranUe.FindAmfUe.RanUe[ranUe.Ran.AnType]) do nothing?
There was a problem hiding this comment.
The ClearHoldingRanUe(ranUe.FindAmfUe.RanUe[ranUe.Ran.AnType]) do noting.
This line had been remove in the latest commit.
andy89923
changed the title
|
Thanks a lot. @ianchen0119 & @ss920386 |
Description
This PR fixes the issue that if the UE is in CM-Idle state, the UE initiating ServiceRequest will require authentication again.
Others
FindAmfUEtoHoldingAmfUe