Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic on terminating SCTP connection #7

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: panic on terminating SCTP connection #7

merged 2 commits into from
Oct 25, 2024

Conversation

blackcat-118
Copy link
Contributor

@blackcat-118 blackcat-118 commented Oct 25, 2024 •
edited by andy89923
Loading

@andy89923 andy89923 requested a review from ianchen0119 October 25, 2024 06:48
ianchen0119
ianchen0119 requested changes Oct 25, 2024
View reviewed changes
internal/ngap/service/service.go Outdated
@@ -118,7 +118,7 @@ func listenAndServe(localAddr, remoteAddr *sctp.SCTPAddr, errChan chan<- error)
n, sctp_info, _, sctpread_err := conn.SCTPRead(data)

if sctpread_err != nil {
ngapLog.Debugf("[SCTP] AMF SCTP address: %+v", conn.RemoteAddr().String())
ngapLog.Debugf("[SCTP] AMF SCTP address: %s", remoteAddr)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

ngapLog.Debugf("[SCTP] AMF SCTP address: %s", remoteAddr.String())

ianchen0119
ianchen0119 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianchen0119 ianchen0119 merged commit 890944b into free5gc:main Oct 25, 2024
3 checks passed
@ianchen0119
Copy link
Collaborator

ianchen0119 commented Oct 25, 2024 •
edited
Loading

@blackcat-118

Please help to update the commit hash in free5gc repo.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy89923 andy89923 andy89923 approved these changes

@ianchen0119 ianchen0119 ianchen0119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bugs] TNGF dies instead of cleanly exiting on terminate
3 participants
@blackcat-118 @ianchen0119 @andy89923