ipa{server,replica,client}: Add parameter to support to install packages only #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bool value defines if the deployment will continue after the needed packages are installed on the node. This is useful if images are generated with the packages installed to speed up deployment. Fixes: freeipa#1086 (Proposal: Add 'installation_only' flag to roles)
rjeffman
requested changes
May 4, 2023
| @@ -359,6 +359,7 @@ Special Variables | |||
| Variable | Description | Required | |||
| -------- | ----------- | -------- | |||
| `ipaserver_install_packages` | The bool value defines if the needed packages are installed on the node. (bool, default: true) | no | |||
| `ipaserver_install_packages_only` | The bool value defines if the deployment will continue after the needed packages are installed on the node. (bool, default: true) | no | |||
There was a problem hiding this comment.
ipaserver/defaults/main.yml has ipaserver_install_packages_only: false, shouldn't the default be false?
Also, I think the value should be true if only the packages should be installed, so, in my opinion, description should be something like "When set to true, required packages will be installed, but server will not be configured. (bool, default: false)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipaserver: New parameter ipaserver_install_packages_only
The bool value defines if the deployment will continue after the needed packages are installed on the node.
This is useful if images are generated with the packages installed to speed up deployment.
Fixes: #1086 (Proposal: Add 'installation_only' flag to roles)
Changes for ipareplica and ipaclient roles need to be done still.