New idp management module #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-woerner
changed the title
t-woerner
force-pushed
the
new_idp_module
branch
3 times, most recently
from
4684dcb to
5dc1dc6
Compare
t-woerner
force-pushed
the
new_idp_module
branch
6 times, most recently
from
e2b590a to
8a8a26a
Compare
t-woerner
force-pushed
the
new_idp_module
branch
2 times, most recently
from
a434677 to
212e290
Compare
rjeffman
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Thank you very much for this PR!
I see minor issues in the code, but I had some issues trying to understand the documentation. It seems we should help users with something about setting up the providers we use as example.
I know we should to explain every IdP endpoint out there, but at least make clear how the ones in the examples have to be used would make things a bit easier.
t-woerner
force-pushed
the
new_idp_module
branch
2 times, most recently
from
84fe006 to
6cc2887
Compare
rjeffman
reviewed
Sep 26, 2023
utils/ansible-freeipa.spec.in
Outdated
| @@ -48,7 +48,9 @@ Features | |||
| - Modules for hbacsvcgroup management | |||
| - Modules for host management | |||
| - Modules for hostgroup management | |||
| - Modules for idoverridegroup management | |||
There was a problem hiding this comment.
Should this be part of this PR?
rjeffman
requested changes
Sep 26, 2023
t-woerner
force-pushed
the
new_idp_module
branch
from
6cc2887 to
434c493
Compare
t-woerner
force-pushed
the
new_idp_module
branch
from
434c493 to
2d079c8
Compare
There is a new idp management module placed in the plugins folder:
plugins/modules/ipaidp.py
The idp module allows to ensure presence or absence of external Identity
Providers.
Here is the documentation for the module:
README-idp.md
New idp example playbooks:
playbooks/idp/idp-present.yml
playbooks/idp/idp-absent.yml
New tests for the module:
tests/idp/test_idp.yml
tests/idp/test_idp_client_context.yml
t-woerner
force-pushed
the
new_idp_module
branch
from
dd4a686 to
f9ff413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new idp management module placed in the plugins folder:
The idp module allows to ensure presence or absence of external Identity Providers.
Here is the documentation for the module:
New idp example playbooks:
New tests for the module: