ipagroup: Add support for renaming groups #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
ipagroup_rename
branch
from
ccb4b34 to
ab1ffee
Compare
varunmylaraiah
approved these changes
Dec 11, 2023
README-group.md
Outdated
|
|
||
| tasks: | ||
| # Rename group appops to webops | ||
| - ipagroup: |
There was a problem hiding this comment.
Using named tasks in example playbooks could enhance clarity.
rjeffman
force-pushed
the
ipagroup_rename
branch
from
ab1ffee to
fc8c5bc
Compare
|
There is no example for rename in the |
t-woerner
reviewed
Dec 19, 2023
plugins/modules/ipagroup.py
Outdated
| @@ -448,7 +460,8 @@ def main(): | |||
| aliases=[ | |||
| "ipaexternalmember", | |||
| "external_member" | |||
| ]) | |||
| ]), | |||
| rename=dict(type="str", required=False, aliases=["new_name"]), | |||
There was a problem hiding this comment.
Is default=None needed additionally?
t-woerner
reviewed
Dec 19, 2023
|
Is it needed to ensure that there will not be a name conflict? Several renames to the same name or a rename to an already existing name? |
New issue for this: #1194 |
Use module_defaults to improve reading test cases.
FreeIPA suports renaming groupobjects with the CLI parameter "rename", and this parameter was missing in ansible-freeipa ipagroup module. This patch adds support for a new state 'renamed' and the 'rename' parameter. Tests were updated to cope with the changes.
rjeffman
force-pushed
the
ipagroup_rename
branch
from
fc8c5bc to
1ecdbd3
Compare
|
Fixed issues found and added proper tests to rename multiple groups at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeIPA suports renaming groupobjects with the CLI parameter "rename",
and this parameter was missing in ansible-freeipa ipagroup module.
This patch adds support for a new state 'renamed' and the 'rename'
parameter.
Tests were updated to cope with the changes.
Fixes #1103