Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Define module parameters only once. #1314

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rjeffman
Copy link
Member

This PR is created over PR #1290 and modifies EntryFactory so that is
instantiates the IPAAnsibleModule and allows the definition of the
module objects only once, while allowing the simple usage case of a
single entry defined in a task, or the case where multiple entries are
used.

Modules ipasudorule and ipagroup are modified to use the new mechanism.

@rjeffman rjeffman requested a review from t-woerner November 18, 2024 21:04
@rjeffman rjeffman force-pushed the entryfactory_steroids branch 2 times, most recently from 670b208 to 873a77e Compare November 19, 2024 11:30
…jects

When setting multiple objects in the same tasks, some validation and
proper capitalization of parameter values were skipped.

By using the EntryFactory to extract the entries data both issues are
fixed.

New test added to ipagroup suite:

    tests/group/test_groups_member_case_insensitive.yml

Note: This is a temporary commit that should be part of another PR. It's
been added here to show the feasiability of the EntryFactory class.
Tests for case insensitive comparison must be added before this change
is merged.
@rjeffman rjeffman force-pushed the entryfactory_steroids branch from 873a77e to c301ec1 Compare November 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant