utils/build-galaxy-release.sh: Do not create duplicates for role plugins #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduces the size of the Ansible collection and removes unused files. While creating the collection, the role plugins have been linked into the global plugin folders, but a subsequent sed call replaced the links with changed files. The original files have also been changed with another sed call in the same way. This resulted in the duplication of the changed files. The plugins of the roles are now moved into the global plugin folders and only changed there. The now empty plugin folders in the roles are removed.
t-woerner
force-pushed
the
no_role_plugin_duplicates
branch
2 times, most recently
from
65d2992 to
edf765c
Compare
ansible-test sanity test "metaclass-boilerplate" fails now to recognize the line "__metaclass__ = type" if there is a pylint disable comment appended to the same line to not fail on using bad class naming. The pylint disable comment has been moved to an extra preceding line and an additional enable commend has been added after the metaclass line.
t-woerner
force-pushed
the
no_role_plugin_duplicates
branch
from
edf765c to
a4f6088
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the size of the Ansible collection and removes unused files.
While creating the collection, the role plugins have been linked into the global plugin folders, but a subsequent sed call replaced the links with changed files. The original files have also been changed with another sed call in the same way. This resulted in the duplication of the changed files.
The plugins of the roles are now moved into the global plugin folders and only changed there. The now empty plugin folders in the roles are removed.