service: Refactor 'delete_continue' to match other modules. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
delete_continue_service_refactor
branch
from
3202434 to
1c8e98c
Compare
|
@varunmylaraiah I agree, I just don't know how to test it properly. We should add a similar test for all the PRs targeting attribute |
rjeffman
force-pushed
the
delete_continue_service_refactor
branch
from
1c8e98c to
3732e7a
Compare
The parameter 'delete_continue' must be supported by several modules, and this patch makes ipaservice module use the same structures as other modules.
rjeffman
force-pushed
the
delete_continue_service_refactor
branch
from
3732e7a to
5560ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
delete_continuemust be supported by several modules,and this patch makes
ipaservicemodule use the same structures as othermodules.
This PR should not be merged before #671