Cast runasuser property to list, consider externaluser members #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get method for ipasudorunas_user and ipasudorunasextuser returns
a tuple instead of a list. Casting to list.
* Consider externaluser members into user list
The externaluser property was not taken into consideration while
building the list of users to add to the sudorule.
rjeffman
reviewed
Mar 24, 2022
| user, res_find.get("memberuser_user")) | ||
| user, | ||
| ( | ||
| res_find.get("memberuser_user", []) |
There was a problem hiding this comment.
When running with ipa_context: client, most member attributes are returned as tuples and not `list', so they need to be "cast" to list.
|
A test for external users should be added. |
|
|
This change will be addressed by PR #1020. Thank you for bringing the issue to our attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast runasuser property from tuple to list
The get method for ipasudorunas_user and ipasudorunasextuser returns
a tuple instead of a list. Casting to list.
Consider externaluser members into user list
The externaluser property was not taken into consideration while
building the list of users to add to the sudorule.