pytest: Add support for defining domain and realm. #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
pytest_allow_configuration_domain_realm
branch
3 times, most recently
from
6aa01a1 to
386004b
Compare
t-woerner
reviewed
Jan 12, 2023
t-woerner
reviewed
Jan 12, 2023
rjeffman
force-pushed
the
pytest_allow_configuration_domain_realm
branch
2 times, most recently
from
1343b21 to
66d8455
Compare
rjeffman
force-pushed
the
pytest_allow_configuration_domain_realm
branch
from
66d8455 to
2066d40
Compare
rjeffman
force-pushed
the
pytest_allow_configuration_domain_realm
branch
from
2066d40 to
f972c0e
Compare
If running ansible-freeipa tests using pytest against an ipaserver with a domain that was not 'test.local', or did not have a zone for that domain, some tests would fail as the 'ipaserver_domain' was set to 'test.local' and some tests rely on that value to setup variables. By allowing a user to define a different domain or realm, all tests will succeed if the domain is set correctly, enhancing development experience and allowing, if needed, in the future, tests that require different domains or realms.
rjeffman
force-pushed
the
pytest_allow_configuration_domain_realm
branch
from
f972c0e to
0b23437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running ansible-freeipa tests using pytest against an ipaserver with a domain that was not 'test.local', or did not have a zone for that domain, some tests would fail as the 'ipaserver_domain' was set to 'test.local' and some tests rely on that value to setup variables.
By allowing a user to define a different domain or realm, all tests will succeed if the domain is set correctly, enhancing development experience and allowing, if needed, in the future, tests that require different domains or realms.