Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add italian translation #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

anthologist
Copy link

No description provided.

Copy link
Collaborator

@dvanbalen dvanbalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

Copy link
Collaborator

@dvanbalen dvanbalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation fails if apostrophes are left un-escaped.

<string name="about_copyright">© 2013 - Red Hat, Inc., et al.</string>
<string name="about_license">FreeOTP ha una licenza %1$s.</string>
<string name="about_website">Per altre informazioni, vedi il nostro %s.</string>
<string name="about_icons">Alcune icone usate da questa applicazione sono riprodotte da lavoro creato e condiviso dall'Android Open Source Project e usate secondo i termini descritti nella Licenza di Attribuzione Creative Commons 2.5.</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apostrophe needs to be escaped (')

Suggested change
<string name="about_icons">Alcune icone usate da questa applicazione sono riprodotte da lavoro creato e condiviso dall'Android Open Source Project e usate secondo i termini descritti nella Licenza di Attribuzione Creative Commons 2.5.</string>
<string name="about_icons">Alcune icone usate da questa applicazione sono riprodotte da lavoro creato e condiviso dall\'Android Open Source Project e usate secondo i termini descritti nella Licenza di Attribuzione Creative Commons 2.5.</string>

<string name="link_website">&lt;a href=&quot;http://freeotp.github.io&quot;&gt;website&lt;/a&gt;</string>
<string name="link_apache2">&lt;a href=&quot;http://www.apache.org/licenses/LICENSE-2.0.html&quot;&gt;Apache 2.0&lt;/a&gt;</string>

<string name="error_camera_open">Errore durante l'accesso alla fotocamera!</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="error_camera_open">Errore durante l'accesso alla fotocamera!</string>
<string name="error_camera_open">Errore durante l\'accesso alla fotocamera!</string>

<string name="link_apache2">&lt;a href=&quot;http://www.apache.org/licenses/LICENSE-2.0.html&quot;&gt;Apache 2.0&lt;/a&gt;</string>

<string name="error_camera_open">Errore durante l'accesso alla fotocamera!</string>
<string name="error_permission_camera_open">L'accesso alla fotocamera non è autorizzato</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="error_permission_camera_open">L'accesso alla fotocamera non è autorizzato</string>
<string name="error_permission_camera_open">L\'accesso alla fotocamera non è autorizzato</string>


<string name="error_camera_open">Errore durante l'accesso alla fotocamera!</string>
<string name="error_permission_camera_open">L'accesso alla fotocamera non è autorizzato</string>
<string name="error_image_open">Errore durante l'apertura dell'immagine!</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="error_image_open">Errore durante l'apertura dell'immagine!</string>
<string name="error_image_open">Errore durante l\'apertura dell'immagine!</string>

byjosh added a commit to byjosh/freeotp-android that referenced this pull request Sep 29, 2020
This is freeotp#184 by @anthologist (https://github.com/anthologist) except the unescaped apostrophes are now escaped as suggested by @dvanbalen (https://github.com/dvanbalen ) . It seemed the lack of a few escaping backslashes were all that was holding the translation up so I've done those. As pull requests are under Apache License https://github.com/freeotp/freeotp-android/blob/master/COPYING I think this is fine - as I am clear about who deserves credit for the actual translation (I'm just the backslash guy).
byjosh added a commit to byjosh/freeotp-android that referenced this pull request Sep 29, 2020
This is freeotp#184 by @anthologist (https://github.com/anthologist) except the unescaped apostrophes are now escaped as suggested by @dvanbalen (https://github.com/dvanbalen ) . It seemed the lack of a few escaping backslashes were all that was holding the translation up so I've done those. As pull requests are under Apache License https://github.com/freeotp/freeotp-android/blob/master/COPYING I think this is fine - as I am clear about who deserves credit for the actual translation (I'm just the backslash guy).
byjosh added a commit to byjosh/freeotp-android that referenced this pull request Sep 29, 2020


This is freeotp#184 by @anthologist (https://github.com/anthologist) except the unescaped apostrophes are now escaped as suggested by @dvanbalen (https://github.com/dvanbalen ) . It seemed the lack of a few escaping backslashes were all that was holding this Italian translation up - so I've done those. As pull requests are under Apache License https://github.com/freeotp/freeotp-android/blob/master/COPYING I think this is fine - as I am clear about who deserves credit for the actual translation (I'm just the backslash guy).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants